[Bug 80778] [bisected regression] piglit spec/glsl-1.50/compiler/incorrect-in-layout-qualifier-repeated-prim.geom

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jul 2 00:14:18 PDT 2014


--- Comment #3 from Jordan Justen <jljusten at gmail.com> ---
(In reply to comment #2)
> Created attachment 102112 [details] [review]
> Patch to fix the issue
> I have reproduced the error. Attached is the patch to fix it.
> Please test it. If it is OK I will send it to the mailing list.

Were you able to verify the patch?

It is usually easier to reply to email with comments.
So, I would suggest just sending it to the list after
you have tested it and feel fairly confident in the

Nevertheless, my comments on the patch are,
how about creating a new local variable?

ast_type_qualifier allowed_duplicates_mask;
allowed_duplicates_mask.flags.i =
   ubo_mat_mask.flags.i |
   ubo_layout_mask.flags.i |
if (state->stage == MESA_SHADER_GEOMETRY)
   allowed_duplicates_mask.flags.i |=

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140702/ecb9ea37/attachment.html>

More information about the intel-3d-bugs mailing list