[Bug 79373] Non-const initializers for matrix and vector constructors

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Jul 19 02:45:21 PDT 2014


Timothy Arceri <t_arceri at yahoo.com.au> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Timothy Arceri <t_arceri at yahoo.com.au> ---
author    Cody Northrop <cody at lunarg.com>    2014-07-10 15:55:31 (GMT)
committer    Kenneth Graunke <kenneth at whitecape.org>    2014-07-14 15:36:36
commit    0f679f0ab5afc8c1469453b922d37ae7216136a4 (patch) (side-by-side diff)

glsl: Fix aggregates with dynamic initializers.

Vectors are falling in to the ir_dereference_array() path. 
Without this change, the following glsl aborts the debug driver, or gets the
wrong answer in release: 
mat2x2 a = mat2( vec2( 1.0, vertex.x ), vec2( 0.0, 1.0 ) ); 
Also submitting piglit tests, will reference in bug.

v2: Rebase on Mesa master. 
v3: Remove unneeded check for arrays, which are covered by
process_array_constructor(), recommended by Timothy Arceri. 

Signed-off-by: Cody Northrop <cody at lunarg.com>
Reviewed-by: Courtney Goeltzenleuchter <courtney at lunarg.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140719/585bba55/attachment.html>

More information about the intel-3d-bugs mailing list