[Bug 78770] [SNB bisected]Webglc conformance/textures/texture-size-limit.html fails

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Nov 4 21:24:46 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=78770

--- Comment #10 from lu hua <huax.lu at intel.com> ---
(In reply to Chad Versace from comment #9)
> Created attachment 108863 [details] [review]
> work-in-progress fix
> 
> Attached patch fixes the bug. intel_miptree_map_gtt() is not 64-bit safe.
> 
> Before submitting the patch to mesa-dev, I need to do a full regression run
> on Piglit. Also, I'd like to make a more general fix.

I test this patch, it still fails.

diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 8fda25d..511d36b 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
@@ -1769,7 +1769,13 @@ intel_miptree_map_gtt(struct brw_context *brw,
       y += image_y;

       map->stride = mt->pitch;
-      map->ptr = base + y * map->stride + x * mt->cpp;
+
+      /* TODO(chadv): Fix this correctly
+       *
+       * Prevent WebGL Conformance test texture-size-limit from segfaulting on
Chrome.
+       * See [https://bugs.freedesktop.org/show_bug.cgi?id=78770].
+       */
+      map->ptr = base + (intptr_t) y * (intptr_t) map->stride + (intptr_t) x *
(intptr_t) mt->cpp;
    }

    DBG("%s: %d,%d %dx%d from mt %p (%s) %d,%d = %p/%d\n", __FUNCTION__,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20141105/7b703677/attachment.html>


More information about the intel-3d-bugs mailing list