[Bug 82920] Invalid read during geometry program build

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=82920

--- Comment #8 from pavol at klacansky.com ---
(In reply to Tapani Pälli from comment #7)
> Created attachment 107763 [details] [review]
> fix for valgrind warnings
> 
> This fix removes invalid access to the deleted resource making valgrind
> happy, it does not fix this bug though.

you can simplify one if statement, here is a proof:

((!earlier && !is_gl_identifier(var->name)) || earlier == NULL)

(!A && !B) || !(A != NULL)
(!A && !B) || !A
(!A || !A) && (!A || !B)
true && (!A || !B)
!A || !B

hence
(!earlier || !is_gl_identifier(var->name))

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20141013/c0879cf4/attachment-0001.html>