[Bug 89580] Implement a NIR -> vec4 pass

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89580

--- Comment #7 from Jason Ekstrand <jason at jlekstrand.net> ---
(In reply to Eduardo Lima Mitev from comment #6)
> (In reply to Jason Ekstrand from comment #5)
> > 1) There are two places so far, brw_type_for_nir_type and
> > brw_conditional_for_nir_comparison, where we would like to put things in a
> > common place.  Recently, I added a brw_nir.h file and I believe Ken added a
> > brw_nir.c file which would be a perfect place to put those.  In fact, we
> > could probably simplify some of the current FS NIR code with your
> > conditionals function.
> >
> 
> Yes, it is a good idea and will leave our code less cluttered. However, I
> will turn brw_nir.c to c++ to add these methods. Any caveat with that?

That's ok if we have a good reason for it.  However, neither of those functions
does anything that requires C++ so I don't see any good reason to change it
either.  They just use #defines that are defined in brw_defines.h and brw_reg.h
both of which are C friendly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150417/843b726b/attachment.html>