[Bug 90175] [hsw bisected][PATCH] atomic counters doesn't work for a binding point different to zero

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90175

--- Comment #1 from Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro at igalia.com> ---
Created attachment 115326
  --> https://bugs.freedesktop.org/attachment.cgi?id=115326&action=edit
Fixes the bug

Taking into account the explanation on the header about the variable binding
(ast.h:553)

   /**
    * Binding specified via GL_ARB_shading_language_420pack's "binding"
keyword.
    *
    * \note
    * This field is only valid if \c explicit_binding is set.
    */
   int binding;

The binding is correct (and should be updated) if explicit_binding is true. But
the correct behaviour was updating it if it was false. 

This was not detected by piglit because all the calls to
glBindBufferBase(GL_ATOMIC_COUNTER_BUFFER are using 0.

I tested this patch by running all piglit on my system, and I didn't detect
regression. I also runned make check without issues.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150425/52a7b745/attachment.html>