[Bug 93215] [Regression bisected] Ogles1conform Automatic mipmap generation test is fail

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93215

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|[SKL] [Regression]          |[Regression bisected]
                   |Ogles1conform Automatic     |Ogles1conform Automatic
                   |mipmap generation test is   |mipmap generation test is
                   |fail                        |fail

--- Comment #2 from Ian Romanick <idr at freedesktop.org> ---
This bug is not specific to SKL.  It affects all platforms that use meta.  I
bisected this to:

commit acbaa3d0fcd2a0d357a4c7539d12877f9838548a
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Nov 13 11:58:41 2015 -0800

    meta/generate_mipmap: Only modify the draw framebuffer binding in
fallback_required

    Previously GL_FRAMEBUFFER was used.  However, if GL_EXT_framebuffer_blit
    is supported (note: it is supported by every Mesa driver), this is
    *sometimes* an alias for GL_DRAW_FRAMEBUFFER (getters) and *sometimes*
    an alias for *both* GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER
    (setters).  As a result, the code saved one binding but modified both.
    If the bindings were different, the GL_READ_FRAMEBUFFER would be
    incorrect on exit.

    Fixes the piglit fbo-generatemipmap-versus-READ_FRAMEBUFFER test.

    Ideally this function would use DSA functions and not modify the binding
    at all.  However, that would be a much more intrusive change because
    _mesa_meta_bind_fbo_image would also need to be modified.
    _mesa_meta_bind_fbo_image has a lot of callers.  Much of this code is
    about to get a major rework due to bug #92363, so I don't think it
    matters too much.  In fact, I discovered this bug while working on the
    other bug.  Le bon temps!

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
    Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
    (cherry picked from commit c40a88b6c5a698e5297957e28cccf2ce23820caa)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151202/d3acc359/attachment.html>