[Bug 93338] [BXT SKL regression] piglit.spec.ext_packed_float.multisample-fast-clear gl_ext_packed_float

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Dec 10 12:28:45 PST 2015


Mark Janes <mark.a.janes at intel.com> changed:

           What    |Removed                     |Added
           Assignee|jljusten at gmail.com          |neil at linux.intel.com

--- Comment #1 from Mark Janes <mark.a.janes at intel.com> ---
I wrote up this bug with flawed information.  This regression appears to have
been caused by the series following Jordan's patch, ending with:

References: master origin/master origin/HEAD
Author:     Neil Roberts <neil at linux.intel.com>
AuthorDate: Thu Nov 19 15:29:19 2015 +0100
Commit:     Neil Roberts <neil at linux.intel.com>
CommitDate: Thu Dec 10 11:03:58 2015 +0000

    blit: Don't take into account the Mesa format when checking MSRT blit

    According to the GLES3 spec, blitting between multisample FBOs with
    different internal formats should not be allowed. The
    compatible_resolve_formats function implements this check. Previously
    it had a shortcut where if the Mesa formats of the two renderbuffers
    were the same then it would assume the blit is ok. However some
    drivers map different internal formats to the same Mesa format, for
    example it might implement both GL_RGB and GL_RGBA textures with
    MESA_FORMAT_R8G8B8A_UNORM. The function is used to generate a GL error
    according to what the GL spec requires so the blit should not be
    allowed in that case. This patch just removes the shortcut so that it
    only ever looks at the internal format.

    Note that I posted a related patch to disable this check altogether
    for desktop GL. However this function is still used on GLES3 because
    there are conformance tests that require this behaviour so this patch
    is still useful.

    Cc: Marek Olšák <maraeo at gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151210/c10eb286/attachment-0001.html>

More information about the intel-3d-bugs mailing list