[Bug 92595] [HSW,BDW,SKL][GLES 3.1 CTS] Big difference in the results for the ES31-CTS.shader_bitfield_operation.* tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92595

--- Comment #8 from Matt Turner <mattst88 at gmail.com> ---
(In reply to Marta Löfstedt from comment #6)
> Created attachment 120561 [details]
> Hack that fix the difference in results between HSW and BDW/SKL
> 
> Sorry, I attached the wrong version of the patch and did the same mistake to
> myself when testing on SKL. It is when I hack BRW_REGISTER_TYPE_UW for both
> signed and unsigned that I pass the imulExtended shader_bitfield tests on
> BDW and SKL(kernel 4.2.0).

Wow, nice. I suspect that is in fact the correct fix -- the MUL intends to
multiply the double word of src[0] with the low word of src[1], not the low
word of src[1] with a reinterpreted sign bit.

Assuming that patch has no regressions, it'll get my Reviewed-by. Thanks Marta!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151218/aff9ba84/attachment.html>