[Bug 87258] [BDW/BSW Bisected]Piglit spec_ARB_shader_atomic_counters_array-indexing fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=87258

--- Comment #7 from Kenneth Graunke <kenneth at whitecape.org> ---
(In reply to Ben Widawsky from comment #5)
> Created attachment 113516 [details] [review]
> VS does the enables differently than ps
> 
> Please test

Hey, nice catch, Ben!  I didn't spot this when I was looking at it a while ago.
 Using the CE register makes a lot of sense.

A couple of suggestions on the patch:
1. Could you put a /* HSW+ */ comment after the #define BRW_ARF_CE 0x40?
2. Could we put the MESA_SHADER_VERTEX case before the uses_kill case, just to
keep the two pixel shader cases together?
3. I think vstride should be 0, not 4...I honestly have no idea why brw_ip_reg
is the way it is, but it's been that way forever.  We should probably also drop
the NOTE! and ? comments.

Assuming the vstride change actually works, and you're good with those
suggestions, feel free to put my R-b on it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150216/e0906fd5/attachment.html>