[Bug 88385] [SNB+ Bisected]Ogles3conform ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels core dumped

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=88385

--- Comment #8 from Iago Toral <itoral at igalia.com> ---
Comment on attachment 112332
  --> https://bugs.freedesktop.org/attachment.cgi?id=112332
patch to fix the issue

Review of attachment 112332:
-----------------------------------------------------------------

::: src/mesa/main/formats.c
@@ +972,4 @@
>        return;
>  
>     case MESA_FORMAT_B10G10R10A2_UNORM:
> +   case MESA_FORMAT_R10G10B10X2_UNORM:

There is a "case MESA_FORMAT_B10G10R10X2_UNORM" a bit below, it is the same
code, but maybe it makes more sense to move the "case
MESA_FORMAT_R10G10B10X2_UNORM" down there so we keep formats with X bits
together.

@@ +1727,5 @@
>     case MESA_FORMAT_A2R10G10B10_UNORM:
>        return format == GL_BGRA && type == GL_UNSIGNED_INT_10_10_10_2;
>  
> +   case MESA_FORMAT_R10G10B10X2_UNORM:
> +      return format == GL_RGB && type == GL_UNSIGNED_INT_2_10_10_10_REV;

I think this might be wrong: looking at other formats with X bits in this same
function, they all return FALSE...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150116/4398ae86/attachment.html>