[Bug 89580] Implement a NIR -> vec4 pass
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Jun 19 21:59:07 PDT 2015
https://bugs.freedesktop.org/show_bug.cgi?id=89580
--- Comment #27 from Kenneth Graunke <kenneth at whitecape.org> ---
(In reply to Jason Ekstrand from comment #26)
> It sounded, from what you said above, like you had already modified
> nir_lower_io to handle vec4. If that's the case just go ahead and do the
> rename and add the vec4 version. No reason to wait for me or Connor to do
> it.
Yeah, I think your approach is great.
Instead of passing a gl_shader_stage and checking for != MESA_SHADER_FRAGMENT,
we should just pass a boolean indicating whether we should make things scalar
or pad to vec4s. Or have nir_lower_io_scalar and nir_lower_io_vec4 functions
(effectively the same thing).
That way, i965's scalar-or-not choices aren't baked into the generic code, and
everybody can pick what they want.
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150620/f36f382e/attachment.html>
More information about the intel-3d-bugs
mailing list