[Bug 92639] [Regression bisected] Ogles1conform mustpass.c fail

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Oct 27 13:09:40 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=92639

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at whitecape.org
            Summary|[Regression] Ogles1conform  |[Regression bisected]
                   |mustpass.c fail             |Ogles1conform mustpass.c
                   |                            |fail

--- Comment #3 from Ian Romanick <idr at freedesktop.org> ---
Bisected to:

fba4823a916b63f279955dbe6d98b6efc666f53e is the first bad commit
commit fba4823a916b63f279955dbe6d98b6efc666f53e
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Fri Aug 28 01:43:23 2015 -0700

    i965: Don't do legacy userclipping in non-compatibility contexts.

    According to the GLSL 1.50 specification, page 76:
    "The shader must also set all values in gl_ClipDistance that have been
     enabled via the OpenGL API, or results are undefined."

    With this patch, we only enable clip distance writes when the shader
    actually writes them.  We no longer force a value to be written when
    clip planes are enabled in the API.  This could mean the first varying
    slot would be used as clip distances - I believe it should be the safe
    kind of undefined behavior.

    Empirically, it doesn't seem to cause a problem.

    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151027/4d75f702/attachment.html>


More information about the intel-3d-bugs mailing list