[Bug 83508] [UBO] Assertion for array of blocks

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=83508

--- Comment #4 from Timothy Arceri <t_arceri at yahoo.com.au> ---
(In reply to Antia Puentes from comment #3)
> (In reply to Timothy Arceri from comment #2)
> > (In reply to Samuel Iglesias from comment #1)
> > > This is going to be fixed by Antía's patch:
> > > 
> > > http://lists.freedesktop.org/archives/mesa-dev/2015-March/079102.html
> > > 
> > > We are planning to send an updated version of this patch in the coming days.
> 
> Hi! Timothy,
> 
> I have a limited knowledge about the linking code but I did take a look at
> how the link_uniform_block_active_visitor works.
> 
> > That will work around the issue for 'shared' and 'std140' but if a shader
> > has a ubo with a 'packed' layout and is unused in the shader it will still
> > hit this same problem right?
> 
> I think it will not. The 'shared' and 'std140' ubo arrays are always marked
> as active, regardless of they being referenced or not in the code. However,
> for 'packed' ubos I can see that they are marked as active by the
> link_uniform_block_active_visitor *only if* there is a reference to them.

ok, so this was the problem. The code was broken for arrays, I've sent a patch
to the mailing list [1] and Cc'd yourself and Ian. Also sent piglit test [2]

[1] http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.html
[2] http://lists.freedesktop.org/archives/piglit/2015-September/017247.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150923/9582a828/attachment.html>