[Bug 97309] piglit.spec.glsl-1_30.compiler.switch-statement.switch-case-duplicated.vert regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97309

            Bug ID: 97309
           Summary: piglit.spec.glsl-1_30.compiler.switch-statement.switch
                    -case-duplicated.vert regression
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: idr at freedesktop.org
          Reporter: mark.a.janes at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org

Bisected to:
mesa ee02a5e330151630be871decde563ddbf192465c
prog_hash_table: Convert to using util/hash_table.h.

Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering
engine booting, rendering a page, and exiting) from 1.8s to 1.1s.  It uses
a large uniform array of structs, making a huge number of separate program
resources, and the fixed-size hash table was killing it.  Given how many
times we've improved performance by swapping the hash table to
util/hash_table.h, just do it once and for all.

This just rebases the old hash table API on top of util/, for minimal
diff.  Cleaning things up is left for later, particularly because I want
to fix up the new hash table API a little bit.

v2: Add UNUSED to the now-unused parameter.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>


Standard Output

/tmp/build_root/m64/lib/piglit/bin/glslparsertest
/tmp/build_root/m64/lib/piglit/tests/spec/glsl-1.30/compiler/switch-statement/switch-case-duplicated.vert
fail 1.30
Shader source:
// [config]
// expect_result: fail
// glsl_version: 1.30
// [end config]
//
// From page 57 (page 63 of the PDF) of the GLSL 1.30 spec:
//
//     "It is an error to have more than one default or a replicated
//      constant-expression."

#version 130

void main() {
   int tmp = 0;
   switch (1) {
   case 0:
   case 0:
      tmp = 1;
   }

   gl_Position = vec4(0.0);
}

Standard Error

Successfully compiled vertex shader
/tmp/build_root/m64/lib/piglit/tests/spec/glsl-1.30/compiler/switch-statement/switch-case-duplicated.vert:

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160811/16c668e6/attachment-0001.html>