[Bug 98409] 4.5% perf drop in CSDof with "nir: Optimize integer division and modulus with 1"

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 28 11:09:27 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=98409

--- Comment #6 from Eero Tamminen <eero.t.tamminen at intel.com> ---
(In reply to Jordan Justen from comment #5)
> When reverting:
> 
> 4d35683 nir: Optimize integer division and modulus with 1
> 
> Did you also revert these?

No.


> 64c3d73 i965/cs: Don't use a thread channel ID for small local sizes
> 1fa000a i965/cs: Use udiv/umod for local IDs
> 
> It would be good to know if taking the current master, and
> reverting these 3 patches regains the 4-5%.

Tried that now.

If one builds commit 4d35683, reverting just that commit fixes the drop.  With
HEAD, that's not enough, but reverting all 3 patches does fix the drop there
too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20161028/a4d2b944/attachment.html>


More information about the intel-3d-bugs mailing list