[Bug 98522] dEQP mandates preprocessor tests for define defined

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98522

--- Comment #2 from Ian Romanick <idr at freedesktop.org> ---
I think https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c22 matches what
dEQP expects.  Basically, C explicitly allows

#define derp defined

According to https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c21, C says
that the following is undefined, but c22 says that all tested C compiler "do
the right thing":

#if derp herp

Just from peeking over Ken's shoulder, I think this is the behavior that dEQP
expects.  As far as I'm aware, WebGL expects errors for this, but GLSL ES and
desktop GLSL have left it also undefined.

I think we should accept these, but we should probably generate warnings.  I
think the warning should occur in the #if line.  I believe this is what glslang
does in its permissive mode.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20161031/aaf923b9/attachment.html>