[Bug 99603] [HSW] assertion in piglit.gl45-cts.arrays_of_arrays_gl.interactionargumentaliasing

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu May 11 21:53:11 UTC 2017


--- Comment #3 from Timothy Arceri <t_arceri at yahoo.com.au> ---
This should not block the release, it doesn't change anything in a release

The asserts were wrong this change just fixes them, the tests just happened to
pass previously and that will not have changed in a release build after this.

The problem is the loop is too large and if I recall correctly that was because
these tests contain a large switch statement which gets wrapped in a loop that
can never be unrolled since the work around in this commit:

commit 73dd50acf6d244979c2a657906aa56d3ac60d550
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Wed Aug 6 09:46:54 2014 +0300

    glsl: implement switch flow control using a loop

    Patch removes old variable based logic for handling a break inside
    switch. Switch is put inside a loop so that existing infrastructure
    for loop flow control can be used for the switch, now also dead code
    elimination works properly.

    Possible 'continue' call inside a switch needs now special handling
    which is taken care of by detecting continue, breaking out and calling
    continue for the outside loop.

    v2: remove one unnecessary ir_expression (Curro)

    Fixes following Piglit tests:


    No Piglit or es3conform regressions.

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Reviewed-by: Francisco Jerez <currojerez at riseup.net>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170511/0fc068a0/attachment.html>

More information about the intel-3d-bugs mailing list