[Bug 103942] KHR-GL46.enhanced_layouts.varying* regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 29 11:16:49 UTC 2017


Juan A. Suarez <jasuarez at igalia.com> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Juan A. Suarez <jasuarez at igalia.com> ---
commit 6d540aa092d5d78dde643af40257444567bf7b95
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Nov 29 12:09:47 2017 +0100

    mesa: deal with vs_inputs as 64-bit unsigned integer

    Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses
    vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer.

    But actually it is a 64-bit integer, and as such it is used in other
    parts of Mesa code. It is worth to note that bits from the entire range
    are used, and not only 32-bits. This is due our implementation for
    handling 64-bit dual-slot input attributes, which requires to use a
    larger bitfield to manage them.

    This commit reverts the changes done in brw_draw_upload.c, keeping the
    rest of the changes.

    This fixes the following tests:

    - KHR-GL45.enhanced_layouts.varying_array_locations
    - KHR-GL45.enhanced_layouts.varying_locations

    Fixes: 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103942
    CC: Marek Olšák <marek.olsak at amd.com>
    CC: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

 src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171129/3b2c0a09/attachment.html>

More information about the intel-3d-bugs mailing list