[Bug 103322] i965: dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 takes 3m22s to compile

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 18 06:22:41 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103322

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mattst88 at gmail.com          |kenneth at whitecape.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Kenneth Graunke <kenneth at whitecape.org> ---
Oh, I think there's actually a simple fix here.

The issue is that add_barrier_dep sets is_barrier = true, and walks backward to
the previous barrier, and forward to...the end of the program...because if
you're walking forward, you haven't set is_barrier on any future instructions
yet.

I think we just need to change to is_scheduling_barrier() instead, which means
moving some things to backend_instruction instead of fs_inst.  (I have a vague
memory that Curro wanted us to do that in the first place...)

I've got a patch to do that, and it reduces the runtime to 3.6 seconds.  The
test still passes, but I'll have to do real regression testing and clean it up
tomorrow.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171018/caa6c978/attachment.html>


More information about the intel-3d-bugs mailing list