[Bug 105497] shader-db crashes on 72 core system after ast_type_qualifier bitset change

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105497

            Bug ID: 105497
           Summary: shader-db crashes on 72 core system after
                    ast_type_qualifier bitset change
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: glsl-compiler
          Assignee: currojerez at riseup.net
          Reporter: kenneth at whitecape.org
        QA Contact: intel-3d-bugs at lists.freedesktop.org

shader-db crashes on our 72-core server (ogopogo):

Thread 38 "run" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffdf3f8700 (LWP 16090)]
ast_type_qualifier::validate_in_qualifier (this=this at entry=0x7fffdf3ec728, 
    loc=loc at entry=0x7fffdf3eb3b4, state=state at entry=0x7ffed491fde0)
    at glsl/ast_type.cpp:653
653        if ((this->flags.i & ~valid_in_mask.flags.i) != 0) {
(gdb) bt
#0  ast_type_qualifier::validate_in_qualifier (this=this at entry=0x7fffdf3ec728, 
    loc=loc at entry=0x7fffdf3eb3b4, state=state at entry=0x7ffed491fde0)
    at glsl/ast_type.cpp:653
#1  0x00007ffff416b901 in _mesa_glsl_parse (state=state at entry=0x7ffed491fde0)
    at ./glsl/glsl_parser.yy:2866
#2  0x00007ffff41758d6 in _mesa_glsl_compile_shader (
    ctx=ctx at entry=0x7ffed4047280, shader=shader at entry=0x7ffed40b7fa0, 
    dump_ast=dump_ast at entry=false, dump_hir=dump_hir at entry=false, 
    force_recompile=force_recompile at entry=false)
    at glsl/glsl_parser_extras.cpp:2089
#3  0x00007ffff3f6845f in _mesa_compile_shader (sh=0x7ffed40b7fa0, 
    ctx=0x7ffed4047280) at main/shaderapi.c:1129
#4  _mesa_CreateShaderProgramv (type=<optimised out>, count=<optimised out>, 
    strings=0x7fffdf3f6e40) at main/shaderapi.c:2510
#5  0x0000000000403521 in main._omp_fn.0 () at run.c:814
#6  0x00007ffff74be43e in ?? () from /usr/lib/x86_64-linux-gnu/libgomp.so.1
#7  0x00007ffff72996ba in start_thread (arg=0x7fffdf3f8700)
    at pthread_create.c:333
#8  0x00007ffff6fcf41d in clone ()
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
(gdb) 

It seems to be some kind of concurrency issue caused by

commit ba79a90fb52e1e81fbfb38113e85a56b13497c50
Author: Francisco Jerez <currojerez at riseup.net>
Date:   Mon Feb 12 14:18:15 2018 -0800

    glsl: Switch ast_type_qualifier to a 128-bit bitset.

At that commit, plus the compile fix (e119c53f56064d8acecfcd22a15ba512c83dfcd0)
cherry-picked on top, I get the crashes.  But commit
bdbc2ffa4219b39e47a27decbc603d445286d92d (the one before that) works fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180314/8ce91a0f/attachment.html>