[Bug 102678] gl_BaseVertex should always be zero when the draw command has no <basevertex> parameter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=102678

Antia Puentes <apuentes at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Antia Puentes <apuentes at igalia.com> ---
Fixed by:

commit 3a1df14a7b5c1652aa72eb6cf43e69ab447c6273

Author: Antia Puentes <apuentes at igalia.com>
Date:   Sat Apr 28 14:09:22 2018 +0200

    intel: activate the gl_BaseVertex lowering

    Surplus code related to the basevertex is removed.

    The Vertex Elements contain now:
    * VE 1: <firstvertex, BaseInstance, VertexID, InstanceID>
    * VE 2: <DrawID, is_indexed_draw, 0, 0>

    Also fixes unreachable message.

    Fixes OpenGL CTS tests:
    * KHR-GL46.shader_draw_parameters_tests.ShaderDrawArraysInstancedParameters
    * KHR-GL46.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters
    *
KHR-GL46.shader_draw_parameters_tests.MultiDrawArraysIndirectCountParameters
    * KHR-GL46.shader_draw_parameters_tests.ShaderDrawArraysParameters
    *
KHR-GL46.shader_draw_parameters_tests.ShaderMultiDrawArraysIndirectParameters

    Fixes Piglit tests:
    * arb_shader_draw_parameters-drawid-indirect baseinstance
    * arb_shader_draw_parameters-basevertex

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102678

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180502/b6b82e8e/attachment.html>