[Bug 108630] [G965] piglit.spec.!opengl 1_2.tex3d-maxsize spins forever

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108630

--- Comment #5 from asimiklit <andrey.simiklit at gmail.com> ---
(In reply to Mark Janes from comment #0)
> bisected to:
> 
> a9031bf9b55602d93cccef6c926e2179c23205b4
> Author:     Andrii Simiklit <andrii.simiklit at globallogic.com>
> 
> i965/batch: avoid reverting batch buffer if saved state is an empty
> 
> There's no point reverting to the last saved point if that save point is
> the empty batch, we will just repeat ourselves.
> 
> CC: Chris Wilson <chris at chris-wilson.co.uk>
> Fixes: 3faf56ffbdeb "intel: Add an interface for saving/restoring
>                      the batchbuffer state."
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107626
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> 
> Previously, this test failed within 3s with:
>  i965: Failed to submit batchbuffer: No space left on device

Yes you are right. It my mistake :(
Sorry for that.
Thanks a lot for your work. 

(In reply to Jordan Justen from comment #3)
> Andrii,
> 
> I found the issue. It is not specific to g965. In the blorp code, on a
> retry, the check_aperture_failed_once variable will be reset back to
> false since we clear things before the retry. This small patch added
> to your change fixes it.
> 
> Another idea could be to preset check_aperture_failed_once before
> the retry label.
> 
> Can you re-submit the patch with this, or a similar change?
> 
> diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> index fd9ce93c6c..7b0f77af25 100644
> --- a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> +++ b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
> @@ -309,7 +309,7 @@ retry:
>     intel_batchbuffer_require_space(brw, 1400);
>     brw_require_statebuffer_space(brw, 600);
>     intel_batchbuffer_save_state(brw);
> -   check_aperture_failed_once = intel_batchbuffer_saved_state_is_empty(brw);
> +   check_aperture_failed_once |=
> intel_batchbuffer_saved_state_is_empty(brw);
>     brw->batch.no_wrap = true;
>  
>  #if GEN_GEN == 6

You are right. Thanks a lot for your fix. 
I will send updated patch shortly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20181102/cd2e961b/attachment-0001.html>