[Bug 108701] [bisected] Failure in Piglit spec.ext_image_dma_buf_import.ext_image_dma_buf_import-intel_external_sampler_with_dma_only

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108701

--- Comment #6 from Lionel Landwerlin <lionel.g.landwerlin at linux.intel.com> ---
(In reply to Aditya Swarup from comment #5)
> I still feel this test is important as it tests one of the corner cases wrt
> EGLImages created using 2D textures and then converted to an external
> texture. 
> 
> We shouldn't have deleted this test, rather renamed it and changed the
> condition for this test to pass when we are using 2D tex to create EGLImages
> and then treating it as an external texture.
> 
> In fact, we lifted the restriction due to a similar test failing for Google
> SKIA test suite - unitTest_EGLImageTest. This is a corner case and spec
> doesn't specifically state this. 
> 
> But it is still useful to catch bugs in future if due to some change in
> MESA, we are unable to create external textures from EGLImages with 2D tex.


That's fair, I didn't really think about that.
And it seems that we don't have any other test left in piglit actually
exercising this.

That being said, creating an EGLImage out of a 2D texture doesn't have much to
do with the EGL_EXT_image_dma_buf_import extension.
A quick look at the VK-GL-CTS repo shows that there are tests exercising that
path (dEQP-EGL.functional.image.api.create_image_gles2_tex2d_rgba).
Since we run both on the Mesa CI, I think that should get you covered.

Thanks for the reminder!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20181115/fef494cc/attachment.html>