[Bug 105301] The big SKQP bug

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105301

--- Comment #34 from Aditya Swarup <aditya.swarup at intel.com> ---
Also, tested patch in #16 for SRGBMipMaps unit test. It passes. :)

@Ken
Can you please pitch in for the debate regarding EGLImage test failure where
the skia test is failing as we are creating EGLImage out of a 2D texture and
then converting it to an external texture. 

It hits the following check in MESA in file intel_tex_image.c:

In intel_image_target_texture_2d():
 /* We support external textures only for EGLImages created with
    * EGL_EXT_image_dma_buf_import. We may lift that restriction in the future.
    */
   if (target == GL_TEXTURE_EXTERNAL_OES && !image->dma_buf_imported) {
      _mesa_error(ctx, GL_INVALID_OPERATION,
            "glEGLImageTargetTexture2DOES(external target is enabled only "
               "for images created with EGL_EXT_image_dma_buf_import");
      return;
   }

Removing this check and the flag dma_buf_imported solves the problem.

I have not submitted the patch upstream but uploaded it for chromium:
https://chromium-review.googlesource.com/c/chromiumos/third_party/mesa/+/1285296

I don't know the logic behind restricting external textures to be only created
using dmabuf. 

Do you feel this can be accepted upstream or Skqp is doing illegal operation
wrt external texture?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20181030/dfacab66/attachment.html>