[Bug 111113] ANGLE BlitFramebufferTest.MultisampleDepthClear/ES3_OpenGL fails on Intel Ubuntu19.04

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111113

Denis <denys.kostin at globallogic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected

--- Comment #5 from Denis <denys.kostin at globallogic.com> ---
Here is a bisected commit:

0ae9ce0f29ea1973b850a4e6c6cae8606973036e is the first bad commit
commit 0ae9ce0f29ea1973b850a4e6c6cae8606973036e
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Sat Aug 19 20:31:03 2017 -0700

    i965/clear: Quantize the depth clear value based on the format

    In f9fd976e8adba733b08d we changed the clear value to be stored as an
    isl_color_value.  This had the side-effect same clear value check is now
    happening directly between the f32[0] field of the isl_color_value and
    ctx->Depth.Clear.  This isn't what we want for two reasons.  One is that
    the comparison happens in floating point even for Z16 and Z24 formats.
    Worse than that, ctx->Depth.Clear is a double so, even for 32-bit float
    formats, we were comparing as doubles and not floats.  This means that
    the test basically always fails for anything other than 0.0f and 1.0f.
    This caused a slight performance regression in Lightsmark 2008 because
    it was using a depth clear value of 0.999 which can't be stored in a
    32-bit float so we were doing unneeded resolves.

    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Bugzilla: https://bugs.freedesktop.org/101678
    Cc: "17.2" <mesa-stable at lists.freedesktop.org>

 src/mesa/drivers/dri/i965/brw_clear.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)


And here is a fix which should fix an issue:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1329

As an original patch was related to benchmark, maybe it makes sense to re-run
that bench one more time (current patch was tested on our CI branch)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190712/3aa27d30/attachment-0001.html>