[Bug 108957] VkRunner tests assert when run with nir test environment variables

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jun 5 20:10:46 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=108957

Jason Ekstrand <jason at jlekstrand.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jason Ekstrand <jason at jlekstrand.net> ---
Fixed by the following two commits in master:

commit fe2fc30cb559f7ef99c07bd219c057b011242cb4
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Tue Jun 4 17:50:22 2019 -0500

    nir: Don't replace the nir_shader when NIR_TEST_SERIALIZE=1

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108957
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Rob Clark <robdclark at chromium.org>

commit 9eba6d9a880558c89a72cbafd873d4fe1247928d
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Tue Jun 4 17:48:33 2019 -0500

    nir: Don't replace the nir_shader when NIR_TEST_CLONE=1

    Instead, we add a new helper which stomps one nir_shader and replaces it
    with another.  The new helper effectively just changes which pointer
    gets used for the base nir_shader.  It should be 99% as good at testing
    cloning but without requiring that everything handle having the shader
    swapped out from under it constantly.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108957
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Rob Clark <robdclark at chromium.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190605/f9cc01bb/attachment.html>


More information about the intel-3d-bugs mailing list