[Bug 58396] [i945GM regression] in 3.7.0 kernel on macbook1,1 (kernel crash)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=58396

--- Comment #13 from Peter Ujfalusi <peter.ujfalusi at gmail.com> ---
(In reply to comment #11)
> More succinct: We did change the sense of the "plane enabled?" check, but we
> also inverted the plane we actually check (see the added ! in reg =
> DSPCNTR(!crtc->plane);)

Hrm, should the crtc->pipe need to be inverted as well?

Based on your earlier comment about the change in the check:
> whereas the new one whether the wrong plane is enabled and on the wrong pipe.

Something like this, so we check on the 'wrong plane' and on the 'wrong pipe':

@@ -8114,7 +8114,7 @@ intel_check_plane_mapping(struct intel_crtc *crtc)
        val = I915_READ(reg);

        if ((val & DISPLAY_PLANE_ENABLE) &&
-           (!!(val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe))
+           (!!(val & DISPPLANE_SEL_PIPE_MASK) == !crtc->pipe))
                return false;

Not sure... Will see when I get my hands on my laptop.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20121217/b6af7d0f/attachment-0001.html>