[Bug 68987] intel-virtual-overlay: only background image and mouse cursor

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Sep 5 09:55:19 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=68987

--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> ---
Whoops, that assert failure was a silly use of sprintf.

commit f01c5eae2a3d6efebe9332a8654303356e622bec
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Sep 5 17:48:20 2013 +0100

    intel-virtual-output: Reserve space for the '\0' in the sprintf

    Even though we don't use the trailing NUL byte for our comparisons,
    sprintf will write it, so we need make space for it.

    Reported-by: Severin Strobl <fd at severin-strobl.de>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68987
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

The idea is that only one intel-virtual-output exists (otherwise we have fun
with multiple processes conflicting over the allocation of VIRTUAL), so if you
run it a second time it sends the request for new screens to the first process.
(There's a timeout for it detection the old process expired.) 

The problem appears to lie in damage tracking. We get nothing reported, so we
don't draw any updates.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130905/a437da51/attachment.html>


More information about the intel-gfx-bugs mailing list