[Bug 68987] intel-virtual-overlay: only background image and mouse cursor

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Sep 5 13:55:54 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=68987

--- Comment #14 from Chris Wilson <chris at chris-wilson.co.uk> ---
Looks ok, no errors, just the damage stops coming. What may be significant is
that it occurs when we reconfigure the screen for the virtual outputs. There
have been a number of Xserver bugs in the past where Damage breaks across a
modeset, so I wonder if this is another...

Maybe this will workaround the issue?

diff --git a/tools/virtual.c b/tools/virtual.c
index 257f37f..4da2f3a 100644
--- a/tools/virtual.c
+++ b/tools/virtual.c
@@ -1760,9 +1760,22 @@ static int display_init_damage(struct display *display)
        if (display->damage == 0)
                return EACCES;

+       display->flush = 1;
        return 0;
 }

+static void display_reset_damage(struct display *display)
+{
+       Damage damage;
+
+       damage = XDamageCreate(display->dpy, display->root,
XDamageReportRawRectangles);
+       if (damage) {
+               XDamageDestroy(display->dpy, display->damage);
+               display->damage = damage;
+               display->flush = 1;
+       }
+}
+
 static void display_init_randr_hpd(struct display *display)
 {
        int major, minor;
@@ -2632,8 +2645,10 @@ int main(int argc, char **argv)
                        ret--;
                }

-               if (reconfigure)
+               if (reconfigure) {
                        context_update(&ctx);
+                       display_reset_damage(ctx.display);
+               }

                if (rr_update) {
                        for (i = 0; i < ctx.nclone; i++)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20130905/abc70b7b/attachment.html>


More information about the intel-gfx-bugs mailing list