[Bug 77767] intel framebuffer broken by d978ef14456a38034f6c0e94a794129501f89200 in kernel 3.15-rc

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77767

--- Comment #8 from Knut Petersen <Knut_Petersen at t-online.de> ---
Yes, that cures the problem. I'd suggest to put the expression after "&&" into
parentheses, otherwise the compiler complains ...

Thanks!

cu,
 Knut


(In reply to comment #7)
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
> b/drivers/gpu/drm/i915/intel_fbdev.c
> index b16116db6c37..24463b643fc8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -133,6 +133,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  
>         mutex_lock(&dev->struct_mutex);
>  
> +       if (intel_fb &&
> +           sizes->fb_width > intel_fb->base.width ||
> +           sizes->fb_height > intel_fb->base.height) {
> +               drm_framebuffer_reference(&ifbdev->fb->base);
> +               intel_fb = NULL;
> +       }
>         if (!intel_fb || WARN_ON(!intel_fb->obj)) {
>                 DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
>                 ret = intelfb_alloc(helper, sizes);

(In reply to comment #7)
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
> b/drivers/gpu/drm/i915/intel_fbdev.c
> index b16116db6c37..24463b643fc8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -133,6 +133,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  
>         mutex_lock(&dev->struct_mutex);
>  
> +       if (intel_fb &&
> +           sizes->fb_width > intel_fb->base.width ||
> +           sizes->fb_height > intel_fb->base.height) {
> +               drm_framebuffer_reference(&ifbdev->fb->base);
> +               intel_fb = NULL;
> +       }
>         if (!intel_fb || WARN_ON(!intel_fb->obj)) {
>                 DRM_DEBUG_KMS("no BIOS fb, allocating a new one\n");
>                 ret = intelfb_alloc(helper, sizes);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140422/fa4f05ea/attachment.html>