[Bug 70839] [IVB] Undocking laptop causes warning in intel_dp_link_down+0x1d2/0x210

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70839

--- Comment #13 from Imre Deak <imre.deak at gmail.com> ---
(In reply to comment #11)
> Ah, sorry that I was looking in a wrong branch.
> Indeed, the commit in question will remove the warning, as it removes the
> call to intel_dp_link_down() from intel_dp_check_link_status().
> However, my understanding is that this call was there to support cases where
> userspace doesn't handle uevents, and removing it will leave DP link on and
> consuming power in such systems, and probably lead to errors when one
> monitor is plugged out and another is plugged in. Hope you are keeping track
> of this in some other bug.

In general we do depend on user space handling uevents, I don't know any reason
why guaranteeing this would pose any problem. So the subsequent modeset disable
should take care of disabling the port. Note that there is still a TODO
identified by Chris, for the case where a modeset fails due to link training
errors and we leave the whole pipeline enabled. But that's a somewhat separate
issue.

> But, for me the problem is fixed, so you can close this one.
> 
> BTW, if relying on uevents is the direction you want to proceed with, I
> think you can remove intel_dp_hot_plug() altogether, since currently it does
> nothing in case of unplug, and in case of plug, the dp link will be enabled
> in intel_enable_dp() anyway, when userspace decides to DPMS_ON.

Afaics intel_dp_hot_plug() also handles link retraining.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140131/d7c2a409/attachment.html>