[Bug 70863] vgaswitcheroo hibernation problem

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70863

--- Comment #4 from Chris Wilson <chris at chris-wilson.co.uk> ---
Just a couple of things I noticed as someone not familiar with vgasr:

1. Can you please put a description of the failure (the user impact) into the
changelog? I am guessing that it spans from excess power usage to blank
displays. It should also explain why we need to restore the old state rather
than waking up userspace in the brave new world, and why we only turn devices
off rather than powering others to match pwr_state.

2. in vga_restore_power_state() it looks like you should be performing a
similar operation to vga_switchon/vga_switchoff, that is you may need a
client->ops->set_gpu_state().

3. vga_switcheroo_disable() should reset mux_state = MUX_STATE_UNDEFINED (or do
so in vga_switcheroo_enable()).

4. vga_restore_mux() failure should probably also reset mux_state =
MUX_STATE_UNDEFINED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20140131/563cc4d6/attachment-0001.html>