[Bug 90137] [ilk] IPS frequently downclocks the GPU when playing quakelive

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 28 09:00:41 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=90137

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
The IPS values are not documented as they were considered to be highly
proprietary information by the hardware designers.

Hmm, I missed the tracepoint. Can you apply:

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index d4d8305c73f5..f84b33bfb724 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3736,6 +3736,9 @@ static bool __ironlake_set_rps(struct drm_i915_private
*dev_priv, u8 val)
        if (WARN_ON(val > dev_priv->rps.max_freq))
                return false;

+       if (val == dev_priv->rps.cur_freq)
+               return true;
+
        assert_spin_locked(&mchdev_lock);

        if (wait_for_atomic((I915_READ(MEMSWCTL) & MEMCTL_CMD_STS) == 0, 10)) {
@@ -3744,6 +3747,8 @@ static bool __ironlake_set_rps(struct drm_i915_private
*dev_priv, u8 val)
        }

        dev_priv->rps.cur_freq = val;
+       trace_intel_gpu_freq_change(val);

or just add a printk there. If you could review the freq<->delay conversion in
the patch, I would be grateful - as that is where the bug most likely lies. We
think in frequency for setting the RPS, but the hw talks delays.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20150428/d2f18b7f/attachment-0001.html>


More information about the intel-gfx-bugs mailing list