[Bug 72765] [ivb efi] Switching from efifb to i915.ko causes a hard hang with fbcon=vc:2-6

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 29 07:02:27 PST 2015


https://bugs.freedesktop.org/show_bug.cgi?id=72765

--- Comment #13 from Chris Wilson <chris at chris-wilson.co.uk> ---
Code review says it is still buggy, e.g.:

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index ea437245562e..90979e32bf4a 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -368,7 +368,7 @@ static void fbcon_update_softback(struct vc_data *vc)
 static void fb_flashcursor(struct work_struct *work)
 {
        struct fb_info *info = container_of(work, struct fb_info, queue);
-       struct fbcon_ops *ops = info->fbcon_par;
+       struct fbcon_ops *ops;
        struct vc_data *vc = NULL;
        int c;
        int mode;
@@ -381,6 +381,7 @@ static void fb_flashcursor(struct work_struct *work)
        if (ret == 0)
                return;

+       ops = info->fbcon_par;
        if (ops && ops->currcon != -1)
                vc = vc_cons[ops->currcon].d;

has a similar unbind race as the original bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20150129/2b585ca6/attachment.html>


More information about the intel-gfx-bugs mailing list