[Bug 89550] [SNB+ Regression bisected]igt/pm_rpm/universal-planes cause call trace

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Mar 19 02:01:39 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=89550

--- Comment #10 from Ding Heng <hengx.ding at intel.com> ---
2fdd7def16dd7580f297827930126c16b152ec11 is the first bad commit
commit 2fdd7def16dd7580f297827930126c16b152ec11
Author: Matt Roper <matthew.d.roper at intel.com>
Date:   Wed Mar 4 10:49:04 2015 -0800

    drm/i915: Don't clobber plane state on internal disables

    We need to disable all sprite planes when disabling the CRTC.  We had
    been using the top-level atomic 'disable' entrypoint to accomplish this,
    which was wrong.  Not only can this lead to various locking issues, it
    also modifies the actual plane state, making it impossible to restore
    the plane properly later.  For example, a DPMS off followed by a DPMS on
    will result in any sprite planes in use not being restored properly.

    The proper solution here is to call directly into our 'commit plane'
    hook with a copy of the plane's current state that has 'visible' set to
    false.  Committing this dummy state will turn off the plane, but will
    not touch the actual plane->state pointer, allowing us to properly
    restore the plane state later.

    Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

:040000 040000 fc36308f0bd42314b67ba401f783e47baaa9d06b
437fc3efb5aa5d569bf3bda658284125724b0d24 M      drivers

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20150319/f81afbd1/attachment-0001.html>


More information about the intel-gfx-bugs mailing list