[Bug 93915] [BXT-P/ APL] xrandr shows DP panel as disconnect after resume from S3

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93915

Jani Nikula <jani.nikula at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Jani Nikula <jani.nikula at intel.com> ---
(In reply to Matt Roper from comment #6)
> (In reply to cprigent from comment #5)
> > Matt,
> > Could you add a comment when the patch is integrated. Then we will check
> > again.
> 
> This patch probably won't be accepted upstream since the review feedback was
> that we should read the value from VBT rather than saving/restoring it.  I
> believe someone from VPG (Sivakumar?) is working on some patches for that.
> 
> The VBT solution won't work on embedded platforms that lack any kind of
> firmware that can provide a VBT, but it should work in most other cases.

Pushed the VBT solution to dinq as

commit d252bf68b75792108ae2821c3a6e1cdc58e88cb9
Author: Shubhangi Shrivastava <shubhangi.shrivastava at intel.com>
Date:   Thu Mar 31 16:11:47 2016 +0530

    drm/i915: Set invert bit for hpd based on VBT

to make progress.

I'm closing this one as fixed, please file another bug about the non-VBT issue.

---

I've been slowly pushing towards abstracting VBT access from the rest of the
driver to hide all the gory details. For example, the above commit adds a
function to query the invert status, instead of directly accessing the VBT
data.

We already have a function init_vbt_defaults() that we call in
intel_bios_init() regardless of whether VBT is present. In this case, I could
imagine adding a function to fill in more of dev_priv->vbt with sensible data
when VBT is not present. Alternatively, the accessor functions could check if
VBT was present or not and provide the data from somewhere else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160406/1cca00db/attachment.html>