[Bug 94337] Linux 4.5 regression: FIFO underruns on Skylake
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Sun Mar 13 23:44:31 UTC 2016
https://bugs.freedesktop.org/show_bug.cgi?id=94337
--- Comment #3 from Andy Lutomirski <luto at mit.edu> ---
There is some highly questionable code in here.
In skl_pipe_wm_get_hw_state:
temp = hw->plane_trans[pipe][PLANE_CURSOR];
skl_pipe_wm_active_state(temp, active, true, true, i, 0);
by "i", do you mean PLANE_CURSOR? This bug probably doesn't matter, because if
is_cursor, then i is ignored. But I'm wondering why there's an is_cursor
parameter at all, given that the code appears to be identical in both cases.
If PLANE_CURSOR is intended to be just like the other planes, why not either
make it plane 0 or have a for_each_plane or similar that iterates over all
plane indices including PLANE_CURSOR?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160313/c7be7057/attachment.html>
More information about the intel-gfx-bugs
mailing list