[Bug 94736] [BAT IGT ALL] drv_module_reload_basic fail on all platforms

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Mar 29 17:08:09 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=94736

--- Comment #19 from Marius Vlad <marius.c.vlad at intel.com> ---
My bad won't happen again. 

Tested with both patches (_init and _exit) and I see no warnings now:

commit 50bd9fb15ccf6f013131f334cd604d783c0c3186
Author: Takashi Iwai <tiwai at suse.de>
Date:   Tue Mar 29 18:48:07 2016 +0200

    ALSA: hda - Fix yet another i915 pointer leftover in error path

    The hdac_acomp object in hdac_i915.c is left as assigned even after
    binding with i915 actually fails, and this leads to the WARN_ON() at
    the next load of the module.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

commit f07183a706c41c8aabef9cd711e45a4ca367aeea
Author: Takashi Iwai <tiwai at suse.de>
Date:   Tue Mar 29 12:29:24 2016 +0200

    ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()

    The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on
    Intel ILK and VLV] introduced a WARN_ON() to check the pointer for
    avoiding the double initializations.  But hdac_acomp pointer wasn't
    cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio
    driver, it may result in the false positive warning.  This patch makes
    sure to clear the leftover pointer at exit.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736
    Reported-by: Daniela Doras-prodan <daniela.doras-prodan at intel.com>
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160329/28aabbe0/attachment.html>


More information about the intel-gfx-bugs mailing list