[Bug 95401] [IVB bisected] assert_scanout:531 assertion 'width == info.width && height == info.height' failed

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 17 06:34:03 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=95401

--- Comment #8 from Chris Wilson <chris at chris-wilson.co.uk> ---
(In reply to Chris Bainbridge from comment #6)
> Created attachment 123795 [details] [review]
> sna-Fix-assert_scanout-regression.patch
> 
> The issue looks like a bug in the bisected commit (the "== 0" at end of
> drmIoctl line was missed), this patch reverts to the previous behaviour.

I didn't even spot it when looking at the commit :( Thanks! The result would be
that we didn't notice the modeset and used the old flip buffer (as the flips
are reported after the change is in effect).

commit ab3ab412a459a95e94707a4e39a18790ee04e6e3
Author: Chris Bainbridge <chris.bainbridge at gmail.com>
Date:   Tue May 17 07:26:10 2016 +0100

    sna: Fix increment of modeset serial after applying CRTC

    We track how many mode sets have been made in order to detect stale
    flips (i.e. a sequence that crosses a mode change). This was broken by
    the logic inversion in setcrc in 46caee86db0f ("sna: Fix reporting of
    errno after setcrtc failure")

    References: https://bugs.freedesktop.org/show_bug.cgi?id=95401
    Signed-off-by: Chris Bainbridge <chris.bainbridge at gmail.com>
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20160517/6c270531/attachment.html>


More information about the intel-gfx-bugs mailing list