[Bug 107365] [drm-tip][BISECT] drm_atomic_helper_wait_for_dependencies fails with flip_done timed out

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107365

Imre Deak <imre.deak at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at chris-wilson.co.uk,
                   |                            |lyude at redhat.com,
                   |                            |ville.syrjala at linux.intel.c
                   |                            |om

--- Comment #6 from Imre Deak <imre.deak at intel.com> ---
(In reply to dmummenschanz at web.de from comment #5)
> Gotcha!
> 
> Found the bad commit (and got a nice learning curve in working with git and
> bisecting the kernel btw. =) )
> 
> https://cgit.freedesktop.org/drm-tip/commit/
> ?id=afb2c4437daeed2d0c49e246ad1ad4def5d913cd
> drm/i915/ddi: Push pipe clock enabling to encoders
> 
> Hope this helps.
> 
> If I can provide anything else plz let me know.
> 
> Regards

Thanks for the bisect (also for Lyude). Could you try if the following solves
it:

commit 2fe0c446f3468ca85055ec93dd9e2524844955cd
Author: Imre Deak <imre.deak at intel.com>
Date:   Fri Aug 31 18:28:31 2018 +0300

    drm/i915/dp_mst: Fix enabling pipe clock for all streams

    Signed-off-by: Imre Deak <imre.deak at intel.com>

diff --git a/drivers/gpu/drm/i915/intel_ddi.c
b/drivers/gpu/drm/i915/intel_ddi.c
index f3b115ce4029..dcb1a98d624d 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2912,7 +2912,8 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder
*encoder,

        icl_enable_phy_clock_gating(dig_port);

-       intel_ddi_enable_pipe_clock(crtc_state);
+       if (!is_mst)
+               intel_ddi_enable_pipe_clock(crtc_state);
 }

 static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,
@@ -3015,14 +3016,14 @@ static void intel_ddi_post_disable_dp(struct
intel_encoder *encoder,
        bool is_mst = intel_crtc_has_type(old_crtc_state,
                                          INTEL_OUTPUT_DP_MST);

-       intel_ddi_disable_pipe_clock(old_crtc_state);
-
-       /*
-        * Power down sink before disabling the port, otherwise we end
-        * up getting interrupts from the sink on detecting link loss.
-        */
-       if (!is_mst)
+       if (!is_mst) {
+               intel_ddi_disable_pipe_clock(old_crtc_state);
+               /*
+                * Power down sink before disabling the port, otherwise we end
+                * up getting interrupts from the sink on detecting link loss.
+                */
                intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
+       }

        intel_disable_ddi_buf(encoder);

diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/intel_dp_mst.c
index 352e5216cc65..77920f1a3da1 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -166,6 +166,8 @@ static void intel_mst_post_disable_dp(struct intel_encoder
*encoder,
        struct intel_connector *connector =
                to_intel_connector(old_conn_state->connector);

+       intel_ddi_disable_pipe_clock(old_crtc_state);
+
        /* this can fail */
        drm_dp_check_act_status(&intel_dp->mst_mgr);
        /* and this can also fail */
@@ -249,6 +251,8 @@ static void intel_mst_pre_enable_dp(struct intel_encoder
*encoder,
        I915_WRITE(DP_TP_STATUS(port), temp);

        ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
+
+       intel_ddi_enable_pipe_clock(pipe_config);
 }

 static void intel_mst_enable_dp(struct intel_encoder *encoder,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180831/3c38eb97/attachment-0001.html>