[Bug 107860] [CI][BAT] igt at drv_selftest@live_hangcheck - igt_reset_engines failed with error

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107860

Martin Peres <martin.peres at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Martin Peres <martin.peres at free.fr> ---
(In reply to Chris Wilson from comment #5)
> The last fix for live_hangcheck was
> 
> commit 9e4fa01221b3230320135072ad31ea809ca31147
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Tue Aug 28 16:27:02 2018 +0100
> 
>     drm/i915/execlists: Flush tasklet directly from reset-finish
>     
>     On finishing the reset, the intention is to restart the GPU before we
>     relinquish the forcewake taken to handle the reset - the goal being the
>     GPU reloads a context before it is allowed to sleep. For this purpose,
>     we used tasklet_flush() which although it accomplished the goal of
>     restarting the GPU, carried with it a sting in its tail: it cleared the
>     TASKLET_STATE_SCHED bit. This meant that if another CPU queued a new
>     request to this engine, we would clear the flag and later attempt to
>     requeue the tasklet on the local CPU, breaking the per-cpu softirq
>     lists.
>     
>     Remove the dangerous tasklet_kill() and just run the tasklet func
>     directly as we know it is safe to do so (the tasklets are internally
>     locked to allow mixed usage from direct submission).
>     
>     Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>     Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>     Cc: Mika Kuoppala <mika.kuoppala at intel.com>
>     Cc: Michel Thierry <michel.thierry at intel.com>
>     Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>     Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20180828152702.27536-1-
> chris at chris-wilson.co.uk

ACK! Thanks for documenting it :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180907/6037bd17/attachment.html>