[Bug 109674] [CI][SHARDS] igt at gem_ctx_param@invalid-param-set - fail - Failed assertion: __gem_context_set_param(fd, &arg) == -22

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109674

--- Comment #5 from Martin Peres <martin.peres at free.fr> ---
(In reply to Chris Wilson from comment #4)
> commit 2551ed1864985d2fe1c250337f86c7b2bc670c67 (upstream/master,
> origin/master, origin/HEAD)
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Mon Feb 18 12:25:50 2019 +0000
> 
>     i915/gem_ctx_param: Remove kneecapping
>     
>     The invalid set/get tests do not serve the purpose of detecting whether
>     or not invalid parameters are indeed detected correctly -- simply because
>     the kernel is the arbiter of what is invalid and this test second
>     guesses that and is wrong.
>     
>     The intent of this test was to ensure that we didn't include any holes
>     in the parameter space that may have been used for nefarious undisclosed
>     purposes, i.e. the maintainer's job backed up by reviewers.
>     
>     As proving no holes is impossible without fuzzing/exhaustive search and
>     a whitelist, accept defeat and just check whether the very last
>     parameter (which should be unused for a long, long time) is invalid.
>     
>     Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>     Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Thanks, it definitely fixed the issues. It used to be 100% reproducible but not
anymore. Last seen on CI_DRM_5814_full (1 week, 1 day old).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190404/75d517c3/attachment-0001.html>