[Bug 110369] [CI][SHARDS] igt at kms_plane_scaling@pipe-[abc]-scaler-with-pixel-format - fail - Failed assertion: (__kms_addfb(fb->fd, fb->gem_handle, fb->width, ... , fb->modifier, fb->strides, fb->offsets, fb->num_planes, flags, &fb->fb_id)) == 0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110369

--- Comment #7 from Mika Kahola <mika.kahola at intel.com> ---
It seems that by adding igt_plane_has_format_mod() check didn't cure the
problem. Earlier I proposed a patch to add kernel supported formats on 90/270
rotation check. Maybe we could reconsider adding this check on igt test?

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3364073c..2d47c14b 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -176,9 +176,25 @@ static const igt_rotation_t rotations[] = {

 static bool can_rotate(data_t *d, unsigned format)
 {
-       if (format == DRM_FORMAT_C8 ||
-           (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
+       switch (format) {
+       case DRM_FORMAT_RGB565:
+               if (intel_gen(d->devid) >= 11)
+                       break;
+       /* fall through */
+       case DRM_FORMAT_C8:
+       case DRM_FORMAT_XRGB16161616F:
+       case DRM_FORMAT_XBGR16161616F:
+       case DRM_FORMAT_ARGB16161616F:
+       case DRM_FORMAT_ABGR16161616F:
+       case DRM_FORMAT_Y210:
+       case DRM_FORMAT_Y212:
+       case DRM_FORMAT_Y216:
+       case DRM_FORMAT_XVYU12_16161616:
+       case DRM_FORMAT_XVYU16161616:
                return false;
+       default:
+               break;
+       }

        return true;
 }
--
2.17.1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190411/16fa3c8a/attachment.html>