[Bug 110380] [CI][SHARDS] igt at gem_exec_schedule@semaphore-codependency - fail - Failed assertion: !"GPU hung"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110380

--- Comment #5 from Martin Peres <martin.peres at free.fr> ---
(In reply to Chris Wilson from comment #4)
> commit b7404c7ecb38b66f103cec694e23a8e99252829e (HEAD ->
> drm-intel-next-queued, drm-intel/for-linux-next,
> drm-intel/drm-intel-next-queued)
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Tue Apr 9 16:29:22 2019 +0100
> 
>     drm/i915: Bump ready tasks ahead of busywaits
>     
>     Consider two tasks that are running in parallel on a pair of engines
>     (vcs0, vcs1), but then must complete on a shared engine (rcs0). To
>     maximise throughput, we want to run the first ready task on rcs0 (i.e.
>     the first task that completes on either of vcs0 or vcs1). When using
>     semaphores, however, we will instead queue onto rcs in submission order.
>     
>     To resolve this incorrect ordering, we want to re-evaluate the priority
>     queue when each of the request is ready. Normally this happens because
>     we only insert into the priority queue requests that are ready, but with
>     semaphores we are inserting ahead of their readiness and to compensate
>     we penalize those tasks with reduced priority (so that tasks that do not
>     need to busywait should naturally be run first). However, given a series
>     of tasks that each use semaphores, the queue degrades into submission
>     fifo rather than readiness fifo, and so to counter this we give a small
>     boost to semaphore users as their dependent tasks are completed (and so
>     we no longer require any busywait prior to running the user task as they
>     are then ready themselves).
>     
>     v2: Fixup irqsave for schedule_lock (Tvrtko)
>     
>     Testcase: igt/gem_exec_schedule/semaphore-codependency
>     Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>     Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>     Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin at intel.com>
>     Cc: Dmitry Ermilov <dmitry.ermilov at intel.com>
>     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20190409152922.23894-1-
> chris at chris-wilson.co.uk

Thanks, this definitely fixed the issue! It used to fail multiple times per run
(~3) and now not seen in 36 runs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190417/e8d1881b/attachment.html>