[Bug 110678] Split "assert (a && b)" statements into "assert(a); assert(b)", for more precise diagnostics

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110678

--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> ---
Whereas I agree with the sentiment, my spot checking shows that logical tests
have been split which do not provide any more information. They do not provide
any of the information that is provided in the trace, and are basically a means
to narrow down the trace.

These asserts should never be enabled by default, or at any time other than
during debugging as they actively destabilize the system by breaking on the
first sign of error that would otherwise be handed normally. They *cause* data
loss.

Since you are debugging, going one step further to enable the trace or attach
gdb and inspect the values is not onerous. So I have to say the patch is mere
churn that doesn't improve debugging one iota.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190515/586ea972/attachment.html>