[PATCH v2 0/3] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

Alan Previn alan.previn.teres.alexis at intel.com
Thu Nov 24 01:31:46 UTC 2022


A customer issue was recently discovered and in the process a
gap in i915's PXP interaction with HW+FW architecure was also
realized. This series adds those missing pieces.
The patches explain the details.

Changes from prior revs:
   v1: - Dont need to teardown non arbitration sessions (Juston).
       - Fix builds when PXP is enabled in config (Alan/CI-build)
       - Fix the broken pm-suspend-resume symmetry when we do this
         pxp-session-teardown during i915s pm_suspend_prepare by
         ensuring the init is done during i915s pm_resume_complete.

Alan Previn (3):
  drm/i915/pxp: Invalidate all PXP fw sessions during teardown
  drm/i915/pxp: Trigger the global teardown for before suspending
  drm/i915/pxp: Pxp hw init should be in resume_complete

 drivers/gpu/drm/i915/gem/i915_gem_pm.c        | 11 ++++
 drivers/gpu/drm/i915/gem/i915_gem_pm.h        |  2 +
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |  7 ++-
 drivers/gpu/drm/i915/gt/intel_gt_pm.h         |  2 +
 drivers/gpu/drm/i915/i915_driver.c            | 16 +++++
 drivers/gpu/drm/i915/pxp/intel_pxp.c          | 60 ++++++++++++++++---
 drivers/gpu/drm/i915/pxp/intel_pxp.h          |  2 +
 .../drm/i915/pxp/intel_pxp_cmd_interface_42.h | 15 +++++
 .../i915/pxp/intel_pxp_cmd_interface_cmn.h    |  3 +
 drivers/gpu/drm/i915/pxp/intel_pxp_pm.c       |  4 +-
 drivers/gpu/drm/i915/pxp/intel_pxp_pm.h       |  6 +-
 drivers/gpu/drm/i915/pxp/intel_pxp_session.c  | 14 ++++-
 drivers/gpu/drm/i915/pxp/intel_pxp_session.h  |  4 ++
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c      | 35 +++++++++++
 drivers/gpu/drm/i915/pxp/intel_pxp_types.h    |  2 +
 15 files changed, 164 insertions(+), 19 deletions(-)


base-commit: 66e5d8e0cdb991feba4fde2c851e700f993d240a
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list