[PATCH] drm/i915/display: Skip PLL state verification in case of unexpected HDP's

Mika Kahola mika.kahola at intel.com
Mon Jun 17 11:11:58 UTC 2024


We ignore link training failures if we discover unexpected long HPD's.
In CI environment these may happen. However, this may lead to a case
where other issues pop up such as PLL mismatches. Let's skip the PLL
state verification in case we ignore the unexpected long HPD's.

Signed-off-by: Mika Kahola <mika.kahola at intel.com>
---
 drivers/gpu/drm/i915/display/intel_cx0_phy.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index 41f684c970dc..5211e9d1f49a 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -3408,6 +3408,16 @@ void intel_cx0pll_state_verify(struct intel_atomic_state *state,
 	struct intel_encoder *encoder;
 	struct intel_cx0pll_state mpll_hw_state = {};
 
+        /*
+	 * Fixed environments like CI, sometimes unexcpected long HPDs are
+	 * generated by the displays. These are ignored in DP link training
+	 * and hence link training failure is also ignored. This may lead to
+	 * a case, where PLL's are not set either so let's skip the PLL state
+	 * verification in this case as well.
+	 */
+	if (i915->display.hotplug.ignore_long_hpd)
+		return;
+
 	if (DISPLAY_VER(i915) < 14)
 		return;
 
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list