[PATCH 7/8] drm/i915/dp: Compute pixel replication count for DSC 12 slices case
Ankit Nautiyal
ankit.k.nautiyal at intel.com
Tue Jun 18 05:50:03 UTC 2024
Add check if pixel replication is required while computing slice count
and fill the pixel replication count in crtc_state.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 68 ++++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +
3 files changed, 69 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index be518af12e4f..55d9819d4b2b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -839,9 +839,32 @@ u16 intel_dp_dsc_get_max_compressed_bpp(struct drm_i915_private *i915,
return bits_per_pixel;
}
+static
+bool can_use_pixel_replication(struct drm_i915_private *i915,
+ int mode_hdisplay, u8 slice_count,
+ enum intel_output_format output_format,
+ bool ultrajoiner)
+{
+ int slice_width;
+
+ if (!(mode_hdisplay % slice_count))
+ return false;
+
+ if (!IS_BATTLEMAGE(i915) || !ultrajoiner)
+ return false;
+
+ slice_width = DIV_ROUND_UP(mode_hdisplay, slice_count);
+
+ /* Odd slice width is not supported by YCbCr420/422 formats */
+ if (slice_width % 2 && output_format == INTEL_OUTPUT_FORMAT_YCBCR420)
+ return false;
+
+ return true;
+}
u8 intel_dp_dsc_get_slice_count(const struct intel_connector *connector,
int mode_clock, int mode_hdisplay,
+ enum intel_output_format output_format,
bool bigjoiner)
{
struct drm_i915_private *i915 = to_i915(connector->base.dev);
@@ -885,8 +908,14 @@ u8 intel_dp_dsc_get_slice_count(const struct intel_connector *connector,
/* big joiner needs small joiner to be enabled */
if (bigjoiner && test_slice_count < 4)
continue;
-
- if (mode_hdisplay % test_slice_count)
+ /*
+ * #TODO Need to use ultrajoiner flag here while checking
+ * for pixel_replication.
+ */
+ if (mode_hdisplay % test_slice_count &&
+ !can_use_pixel_replication(i915, mode_hdisplay,
+ test_slice_count,
+ output_format, false))
continue;
if (min_slice_count <= test_slice_count)
@@ -1288,6 +1317,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
intel_dp_dsc_get_slice_count(connector,
target_clock,
mode->hdisplay,
+ output_format,
joiner);
}
@@ -2190,6 +2220,36 @@ static int intel_edp_dsc_compute_pipe_bpp(struct intel_dp *intel_dp,
return 0;
}
+static
+int intel_dp_dsc_get_pixel_replication(struct intel_dp *intel_dp,
+ struct intel_crtc_state *pipe_config)
+{
+ struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+ int mode_hdisplay = pipe_config->hw.adjusted_mode.hdisplay;
+ int slice_count = pipe_config->dsc.slice_count;
+ int pixel_replication_count;
+ int slice_width;
+
+ /*
+ * #TODO Need to send ultrajoiner flag here instead of false
+ */
+ if (!can_use_pixel_replication(i915, mode_hdisplay,
+ slice_count, false,
+ pipe_config->output_format))
+ return 0;
+
+ slice_width = DIV_ROUND_UP(mode_hdisplay, slice_count);
+
+ pixel_replication_count = (slice_width * slice_count) - mode_hdisplay;
+
+ if (pixel_replication_count >= 0)
+ return pixel_replication_count;
+
+ return 0;
+}
+
+
int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
struct intel_crtc_state *pipe_config,
struct drm_connector_state *conn_state,
@@ -2252,6 +2312,7 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
intel_dp_dsc_get_slice_count(connector,
adjusted_mode->crtc_clock,
adjusted_mode->crtc_hdisplay,
+ pipe_config->output_format,
pipe_config->joiner_pipes);
if (!dsc_dp_slice_count) {
drm_dbg_kms(&dev_priv->drm,
@@ -2261,6 +2322,9 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
pipe_config->dsc.slice_count = dsc_dp_slice_count;
}
+
+ pipe_config->dsc.pixel_replication_count =
+ intel_dp_dsc_get_pixel_replication(intel_dp, pipe_config);
/*
* VDSC engine operates at 1 Pixel per clock, so if peak pixel rate
* is greater than the maximum Cdclock and if slice count is even
diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
index a0f990a95ecc..a266d48c3b30 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.h
+++ b/drivers/gpu/drm/i915/display/intel_dp.h
@@ -151,6 +151,7 @@ int intel_dp_dsc_sink_max_compressed_bpp(const struct intel_connector *connector
int bpc);
u8 intel_dp_dsc_get_slice_count(const struct intel_connector *connector,
int mode_clock, int mode_hdisplay,
+ enum intel_output_format output_format,
bool bigjoiner);
bool intel_dp_need_joiner(struct intel_dp *intel_dp,
struct intel_connector *connector,
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 27ce5c3f5951..e46874494585 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -105,6 +105,7 @@ static int intel_dp_mst_bw_overhead(const struct intel_crtc_state *crtc_state,
dsc_slice_count = intel_dp_dsc_get_slice_count(connector,
adjusted_mode->clock,
adjusted_mode->hdisplay,
+ crtc_state->output_format,
crtc_state->joiner_pipes);
}
@@ -1468,6 +1469,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
intel_dp_dsc_get_slice_count(intel_connector,
target_clock,
mode->hdisplay,
+ INTEL_OUTPUT_FORMAT_RGB,
joiner);
}
--
2.40.1
More information about the Intel-gfx-trybot
mailing list