[PATCH 02/10] drm/i915/dp: fix the Adaptive sync Operation mode for SDP

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Intel-gfx-trybot <intel-gfx-trybot-bounces at lists.freedesktop.org> On
> Behalf Of Ankit Nautiyal
> Sent: Tuesday, June 18, 2024 12:03 PM
> To: intel-gfx-trybot at lists.freedesktop.org
> Subject: [PATCH 02/10] drm/i915/dp: fix the Adaptive sync Operation mode for
> SDP
> 
> Currently we support Adaptive sync operation mode with dynamic frame rate,
> but instead the operation mode with fixed rate is set.
> This was initially set correctly in the earlier version of changes but later got
> changed, while defining a macro for the same.
> 
> Fixes: a5bd5991cb8a ("drm/i915/display: Compute AS SDP parameters")
> Cc: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 3903f6ead6e6..3f46e13bb7b8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2631,7 +2631,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp
> *intel_dp,
> 
>  	crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
> 
> -	/* Currently only DP_AS_SDP_AVT_FIXED_VTOTAL mode supported */
>  	as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
>  	as_sdp->length = 0x9;
>  	as_sdp->duration_incr_ms = 0;
> @@ -2643,7 +2642,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp
> *intel_dp,
>  		as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
>  		as_sdp->target_rr_divider = true;
>  	} else {
> -		as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
> +		as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;

Changes LGTM.
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>

>  		as_sdp->vtotal = adjusted_mode->vtotal;
>  		as_sdp->target_rr = 0;
>  	}
> --
> 2.40.1